Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-release tests #1435

Merged
merged 1 commit into from Mar 22, 2024
Merged

Fix pre-release tests #1435

merged 1 commit into from Mar 22, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Mar 22, 2024

@ilan-gold this should unblock you

See #1434 (doesn‘t fix that one though)

Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with upper bounding packages. I will take a look at the issue. Is @ivirshup ok with upper bounding this? I can't think of a good reason not to but he often has something up his sleeve!

@flying-sheep
Copy link
Member Author

flying-sheep commented Mar 22, 2024

I’m usually the “no upper bounds” guy. Here’s the reasoning why it’s OK in cases like this:

Scipy is unlikely to change their implementation to not use copy=True, so it’s 1. on us to make this work and 2. a !=1.13.0.rc1 constraint won‘t be sufficient.

Therefore all anndata versions that don’t have the future fix are incompatible with all future scipy versions. Therefore a temporary upper bound (with a comment linking to the issue) is the right call.

In an ideal world, all past anndata versions would have the same bound, but that’s impossible to do.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (8f4c755) to head (fbfa3b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1435      +/-   ##
==========================================
- Coverage   86.29%   84.09%   -2.21%     
==========================================
  Files          36       36              
  Lines        5612     5602      -10     
==========================================
- Hits         4843     4711     -132     
- Misses        769      891     +122     
Flag Coverage Δ
gpu-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@flying-sheep flying-sheep merged commit 98d33da into main Mar 22, 2024
20 of 23 checks passed
@flying-sheep flying-sheep deleted the fix-pre-tests branch March 22, 2024 15:20
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Mar 22, 2024
@ivirshup
Copy link
Member

Tbf, I did also write the scipy patch that introduced this.

@ivirshup
Copy link
Member

In an ideal world, all past anndata versions would have the same bound, but that’s impossible to do.

I believe conda-forge actually allows this

ivirshup pushed a commit that referenced this pull request Mar 22, 2024
Co-authored-by: Philipp A <flying-sheep@web.de>
@flying-sheep
Copy link
Member Author

Yeah, I was thinking about PyPI. There it would also kinda maybe be possible by yanking everything and releasing .post1 releases but I don't think that's a reasonable standard to hold ourselves to and it would force people to change their lock files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants