New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre-release tests #1435
Fix pre-release tests #1435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with upper bounding packages. I will take a look at the issue. Is @ivirshup ok with upper bounding this? I can't think of a good reason not to but he often has something up his sleeve!
I’m usually the “no upper bounds” guy. Here’s the reasoning why it’s OK in cases like this: Scipy is unlikely to change their implementation to not use Therefore all anndata versions that don’t have the future fix are incompatible with all future scipy versions. Therefore a temporary upper bound (with a comment linking to the issue) is the right call. In an ideal world, all past anndata versions would have the same bound, but that’s impossible to do. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1435 +/- ##
==========================================
- Coverage 86.29% 84.09% -2.21%
==========================================
Files 36 36
Lines 5612 5602 -10
==========================================
- Hits 4843 4711 -132
- Misses 769 891 +122
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tbf, I did also write the scipy patch that introduced this. |
I believe conda-forge actually allows this |
Co-authored-by: Philipp A <flying-sheep@web.de>
Yeah, I was thinking about PyPI. There it would also kinda maybe be possible by yanking everything and releasing .post1 releases but I don't think that's a reasonable standard to hold ourselves to and it would force people to change their lock files |
@ilan-gold this should unblock you
See #1434 (doesn‘t fix that one though)