Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

account for obsp/varp during transpose #370

Merged
merged 7 commits into from May 14, 2020
Merged

account for obsp/varp during transpose #370

merged 7 commits into from May 14, 2020

Conversation

falexwolf
Copy link
Member

No description provided.

ivirshup
ivirshup reviewed May 13, 2020
View reviewed changes
Copy link
Member

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes:

  • Could there be a test that this works?
  • Could the constructor of the new AnnData use key word arguments for the other elements?

anndata/_core/anndata.py Outdated
Comment on lines 1280 to 1281
obsp=self.varp,
varp=self.obsp,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should copies get made here?

@falexwolf falexwolf merged commit 58f1eac into master May 14, 2020
@falexwolf falexwolf deleted the obsp-transpose branch June 6, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivirshup ivirshup ivirshup left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@falexwolf @ivirshup