Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update write_loom to write layers #53

Merged
merged 7 commits into from
Aug 31, 2018
Merged

Conversation

VolkerBergen
Copy link
Contributor

No description provided.

@VolkerBergen VolkerBergen changed the title update write_loom to write layers update write_loom to write layers Aug 23, 2018
@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

Merging #53 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   64.94%   64.89%   -0.05%     
==========================================
  Files           9        9              
  Lines         716      715       -1     
==========================================
- Hits          465      464       -1     
  Misses        251      251
Impacted Files Coverage Δ
anndata/readwrite/write.py 69.38% <100%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbef0bc...12d2600. Read the comment docs.

@flying-sheep
Copy link
Member

Could you please add a test validating that an AnnData object with layers can be correctly written and read again?

@VolkerBergen
Copy link
Contributor Author

Sure, done.

@flying-sheep
Copy link
Member

where? i mean in this PR’s branch. and please make it a separate test, not new asserts in an old one 😃

@falexwolf
Copy link
Member

Yes @VolkerBergen, please add a test. I don't see where you have added it.

@flying-sheep
Copy link
Member

he added it in another PR, but should add it in this one.

@VolkerBergen if you don’t want to do the whole checkout dance you can also go to the file on branch patch-3 online and edit it there

@flying-sheep
Copy link
Member

flying-sheep commented Aug 30, 2018

OK, to fix python 3.5, you have to add

import pytest
from importlib.util import find_spec
...
pytest.mark.skipif(find_spec('loompy') is None, reason="loompy not installed")
def test_readwrite_loom():
   ...

and for 3.6… apparently loompy now depends on matplotlib but don’t mention that.

either wait until linnarsson-lab/loompy#68 is fixed or add matplotlib to requirements-test.txt

@flying-sheep flying-sheep merged commit db90523 into scverse:master Aug 31, 2018
@flying-sheep
Copy link
Member

looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants