-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update write_loom to write layers #53
Conversation
write_loom
to write layers
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 64.94% 64.89% -0.05%
==========================================
Files 9 9
Lines 716 715 -1
==========================================
- Hits 465 464 -1
Misses 251 251
Continue to review full report at Codecov.
|
Could you please add a test validating that an AnnData object with layers can be correctly written and read again? |
Sure, done. |
where? i mean in this PR’s branch. and please make it a separate test, not new asserts in an old one 😃 |
Yes @VolkerBergen, please add a test. I don't see where you have added it. |
he added it in another PR, but should add it in this one. @VolkerBergen if you don’t want to do the whole checkout dance you can also go to the file on branch patch-3 online and edit it there |
OK, to fix python 3.5, you have to add import pytest
from importlib.util import find_spec
...
pytest.mark.skipif(find_spec('loompy') is None, reason="loompy not installed")
def test_readwrite_loom():
... and for 3.6… apparently loompy now depends on either wait until linnarsson-lab/loompy#68 is fixed or add matplotlib to |
looks great, thank you! |
No description provided.