Fix for _validate_palette for old numpy versions, prepare 1.9.8 hotfi…

…x release (#2832)
scverse · Jan 26, 2024 · 72780fc · 72780fc
1 parent bf5f27a
commit 72780fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/docs/release-notes/1.9.8.md b/docs/release-notes/1.9.8.md
@@ -1,4 +1,5 @@
-### 1.9.8 {small}`the future`
+### 1.9.8 {small}`2024-01-26`
 
 ```{rubric} Bug fixes
 ```
+- Fix handling of numpy array palettes for old numpy versions {pr}`2832` {smaller}`P Angerer`
diff --git a/scanpy/plotting/_utils.py b/scanpy/plotting/_utils.py
@@ -380,8 +380,8 @@ def _validate_palette(adata: AnnData, key: str) -> None:
                 _palette = None
                 break
         _palette.append(color)
-    # Don't modify if nothing changed
-    if _palette is None or np.equal(_palette, adata.uns[color_key]).all():
+    # Don’t modify if nothing changed
+    if _palette is None or np.array_equal(_palette, adata.uns[color_key]):
         return
     adata.uns[color_key] = _palette