Fix library_id types (#2541)

scverse · Jul 21, 2023 · 9f27fc9 · 9f27fc9
1 parent 0594b7f
commit 9f27fc9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/scanpy/plotting/_tools/scatterplots.py b/scanpy/plotting/_tools/scatterplots.py
@@ -923,7 +923,7 @@ def spatial(
     basis: str = "spatial",
     img: Union[np.ndarray, None] = None,
     img_key: Union[str, None, Empty] = _empty,
-    library_id: Union[str, Empty] = _empty,
+    library_id: Union[str, None, Empty] = _empty,
     crop_coord: Tuple[int, int, int, int] = None,
     alpha_img: float = 1.0,
     bw: Optional[bool] = False,
@@ -1289,7 +1289,7 @@ def _check_scale_factor(
 
 
 def _check_spatial_data(
-    uns: Mapping, library_id: Union[Empty, None, str]
+    uns: Mapping, library_id: Union[str, None, Empty]
 ) -> Tuple[Optional[str], Optional[Mapping]]:
     """
     Given a mapping, try and extract a library id/ mapping with spatial data.

diff --git a/scanpy/readwrite.py b/scanpy/readwrite.py
@@ -338,7 +338,7 @@ def read_visium(
     genome: Optional[str] = None,
     *,
     count_file: str = "filtered_feature_bc_matrix.h5",
-    library_id: str = None,
+    library_id: Optional[str] = None,
     load_images: Optional[bool] = True,
     source_image_path: Optional[Union[str, Path]] = None,
 ) -> AnnData: