Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated louvain rapids method #1079

Merged
merged 2 commits into from Mar 3, 2020
Merged

Fix deprecated louvain rapids method #1079

merged 2 commits into from Mar 3, 2020

Conversation

LouisFaure
Copy link
Contributor

@LouisFaure LouisFaure commented Mar 1, 2020 •
edited

Hello,

GPU accelerated louvain community method call nvLouvain has been deprecated.
Now it should be run as follow: df, mod = cugraph.louvain(G)

ivirshup
ivirshup requested changes Mar 1, 2020
View reviewed changes
Copy link
Member

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you also add the relevant version restrictions here?

@LouisFaure
Copy link
Contributor Author

Thanks for the PR! Could you also add the relevant version restrictions here?

Sure! I have added version restriction for cuml and cudf as well for consistency

ivirshup
ivirshup approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@ivirshup ivirshup merged commit 7e058a1 into scverse:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivirshup ivirshup ivirshup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LouisFaure @ivirshup