Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed randomness in tl.diffmap - compute_eigen (v0 argument) #1858

Merged
merged 7 commits into from Jun 22, 2021
Merged

Fixed randomness in tl.diffmap - compute_eigen (v0 argument) #1858

merged 7 commits into from Jun 22, 2021

Commits on May 27, 2021

  1. Fixed randomness in compute_eigen (v0 argument) 

    Added the random_state arguments to:
- tools/_diffmap.py _diffmap (tl.diffmap function)
- tools/_dpt.py _diffmap
- neighbors/__init__.py compute_eigen

random_state is used to set the random state for generation
of the v0 argument for scipy.sparse.linalg.eigsh
Otherwise each subsequent function call generates different results.
    @Iwo-K
    Iwo-K committed May 27, 2021
    Configuration menu
    Copy the full SHA
    a11d6cd View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2021

  1. Using random_state method instead of numpy.random

    @Iwo-K
    Iwo-K committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    f2c462e View commit details
    Browse the repository at this point in the history

  2. Added a test for tl.diffmap reproducibility

    @Iwo-K
    Iwo-K committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    8964346 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Text formatting 

    Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
    @Iwo-K @ivirshup
    Iwo-K and ivirshup committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    7ed902c View commit details
    Browse the repository at this point in the history

  2. Removed specifying global random state in compute_eigen (unnecessary)

    @Iwo-K
    Iwo-K committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    d3ca6c8 View commit details
    Browse the repository at this point in the history

  3. Added release note for PR1858

    @Iwo-K
    Iwo-K committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    84b9f6f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into diffmap_fix

    @ivirshup
    ivirshup committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    6fc238e View commit details
    Browse the repository at this point in the history