Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scatter palette name #2571

Merged
merged 9 commits into from Oct 9, 2023
Merged

Fix scatter palette name #2571

merged 9 commits into from Oct 9, 2023

Conversation

flying-sheep
Copy link
Member

Fixes #1438

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #2571 (6586901) into master (3064bf1) will increase coverage by 0.28%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2571      +/-   ##
==========================================
+ Coverage   71.69%   71.97%   +0.28%     
==========================================
  Files         108      108              
  Lines       11908    11905       -3     
==========================================
+ Hits         8537     8569      +32     
+ Misses       3371     3336      -35     
Files Coverage Δ
scanpy/plotting/_anndata.py 83.24% <100.00%> (+2.36%) ⬆️
scanpy/plotting/_utils.py 55.91% <100.00%> (+2.39%) ⬆️

... and 1 file with indirect coverage changes

@flying-sheep flying-sheep marked this pull request as ready for review July 24, 2023 09:01
@flying-sheep flying-sheep added this to the 1.9.4 milestone Jul 24, 2023
@flying-sheep flying-sheep modified the milestones: 1.9.4, 1.9.5 Aug 24, 2023
@ivirshup ivirshup modified the milestones: 1.9.5, 1.9.6 Sep 8, 2023
@flying-sheep flying-sheep enabled auto-merge (squash) October 6, 2023 13:42
@flying-sheep flying-sheep merged commit 555b668 into master Oct 9, 2023
10 checks passed
@flying-sheep flying-sheep deleted the fix-scatter-palette-name branch October 9, 2023 11:59
@scverse scverse deleted a comment from lumberbot-app bot Oct 9, 2023
flying-sheep added a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scanpy.pl.scatter doesn't accept strings as color palettes
2 participants