Layers support for PCA and regress_out #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2588 +/- ##
=======================================
Coverage 72.12% 72.12%
=======================================
Files 104 104
Lines 11688 11688
=======================================
Hits 8430 8430
Misses 3258 3258
|
ivirshup
reviewed
Aug 3, 2023
scanpy/tests/test_pca.py
Outdated
Comment on lines
170
to
175
| assert np.allclose(X_pca.uns["pca"]["variance"], layer_pca.uns["pca"]["variance"]) | ||
| assert np.allclose( | ||
| X_pca.uns["pca"]["variance_ratio"], layer_pca.uns["pca"]["variance_ratio"] | ||
| ) | ||
| assert np.allclose(X_pca.obsm['X_pca'], layer_pca.obsm['X_pca']) | ||
| assert np.allclose(X_pca.varm['PCs'], layer_pca.varm['PCs']) |
There was a problem hiding this comment.
These should be exactly equal, right?
There was a problem hiding this comment.
Also maybe checkout scanpy.testing._helpers.check_rep_results
ivirshup
requested changes
Aug 3, 2023
ivirshup
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
.layerssupport for PCA and regress_out.