Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of AnnData constructor dtype kwarg #2658

Merged
merged 3 commits into from Sep 8, 2023

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Sep 8, 2023

As it's scheduled to be removed in anndata 0.10.0.

This will require a quick bug fix release. It may also require bumping the anndata dependency to >0.8.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2658 (32c1ab6) into master (3a50e60) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 32c1ab6 differs from pull request most recent head 8e75cef. Consider uploading reports for the commit 8e75cef to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2658   +/-   ##
=======================================
  Coverage   72.16%   72.16%           
=======================================
  Files         108      108           
  Lines       11906    11906           
=======================================
  Hits         8592     8592           
  Misses       3314     3314           
Files Changed Coverage Δ
scanpy/datasets/_datasets.py 69.29% <100.00%> (ø)
scanpy/testing/_helpers/__init__.py 100.00% <100.00%> (ø)

@ivirshup ivirshup enabled auto-merge (squash) September 8, 2023 19:16
@ivirshup ivirshup merged commit 0b49eeb into scverse:master Sep 8, 2023
9 checks passed
ivirshup added a commit to ivirshup/scanpy that referenced this pull request Sep 8, 2023
* Remove use of AnnData constructor dtype kwarg

* release note

* Fix release note

(cherry picked from commit 0b49eeb)
ivirshup added a commit that referenced this pull request Sep 8, 2023
* Remove use of AnnData constructor dtype kwarg (#2658)

* Remove use of AnnData constructor dtype kwarg

* release note

* Fix release note

(cherry picked from commit 0b49eeb)

* Fix test

* Set release date

* Add release notes to index
@scverse scverse deleted a comment from lumberbot-app bot Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants