Compatibility with Palantir>=v1.3.0 #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2672 +/- ##
=======================================
Coverage 72.16% 72.16%
=======================================
Files 108 108
Lines 11908 11908
=======================================
Hits 8593 8593
Misses 3315 3315
|
flying-sheep
approved these changes
Oct 16, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
Oct 16, 2023
|
ah, and I forgot to add release notes. I need to get #2569 done … |
flying-sheep
changed the title
flying-sheep
pushed a commit
that referenced
this pull request
Oct 16, 2023
…0) (#2690) Co-authored-by: Dominik J. Otto <dominik.otto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves Issue #2608 in Scanpy by ensuring compatibility with both Palantir v1.3.0 (function signature) and its earlier versions. This is achieved by substituting the initial keyword argument (
data_df) with a positional argument.The change aligns with Palantir v1.3.0's new optionality to accept AnnData objects as the first argument, making the keyword
data_dfpotentially misleading. Adopting a positional argument ensures compatibility with both new and prior versions of Palantir.