Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen exact equality restriction #2687

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Loosen exact equality restriction #2687

merged 5 commits into from
Oct 16, 2023

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Oct 16, 2023

They kept failing. Something upstream (likely numba) or Azure’s testing machines seem to have become less consistent in calculating this. This thread came across that. @ivirshup’s final statement was

This bug seems to be based on having nested parallelism and certain reductions. We can avoid it by just not having nested parallelism, which is what I've done for gearys_c.

I don’t think exact float equality is a reasonable assumption, but if we want to continue to test for it, we need to be able to force numba to be predictable or so.

Needs no release note.

Added #2688 to track this regression

@flying-sheep flying-sheep changed the title Loosen exact equality restriction Loosen exact equality restriction for metrics tests Oct 16, 2023
@flying-sheep flying-sheep added this to the 1.9.6 milestone Oct 16, 2023
@flying-sheep flying-sheep enabled auto-merge (squash) October 16, 2023 09:44
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@8353e45). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 601888e differs from pull request most recent head f257b7f. Consider uploading reports for the commit f257b7f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2687   +/-   ##
=========================================
  Coverage          ?   71.97%           
=========================================
  Files             ?      108           
  Lines             ?    11907           
  Branches          ?        0           
=========================================
  Hits              ?     8570           
  Misses            ?     3337           
  Partials          ?        0           

@flying-sheep flying-sheep changed the title Loosen exact equality restriction for metrics tests Loosen exact equality restriction Oct 16, 2023
@flying-sheep flying-sheep enabled auto-merge (squash) October 16, 2023 13:02
@flying-sheep flying-sheep merged commit 42e3c2a into master Oct 16, 2023
10 checks passed
@flying-sheep flying-sheep deleted the loosen-metrics-tests branch October 16, 2023 13:09
@scverse scverse deleted a comment from lumberbot-app bot Oct 16, 2023
@flying-sheep flying-sheep mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant