Fix for highly_variable_genes flavor=seurat modifying layer #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2698 +/- ##
==========================================
+ Coverage 71.99% 72.01% +0.01%
==========================================
Files 108 108
Lines 11931 11934 +3
==========================================
+ Hits 8590 8594 +4
+ Misses 3341 3340 -1
|
flying-sheep
requested changes
Oct 19, 2023
|
OK! This is a bugfix, so I added this PR to the bugfix milestone. Please add a release note for 1.9.6, then it’s ready! |
flying-sheep
approved these changes
Oct 19, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
Oct 19, 2023
… modifying layer
flying-sheep
pushed a commit
that referenced
this pull request
Oct 19, 2023
…ing layer (#2700) Co-authored-by: Eljas Roellin <65244425+eroell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2668.
sc.pp.highly_variable_genes(adata, flavor='seurat')modified the usedlayerin some cases, as described in #2668.This PR fixes this behaviour, and adds additional tests.