Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated_func decorator #2714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glitchheadgit
Copy link

Can you give a dict of deprecated functions and there new analogues?
Then we can add f"Use {new_func[deprecated_func]} instead." for raise FutureWarning.

  • Release notes not necessary because:
    Too small issue

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ec7f925) 71.99% compared to head (4dc9c86) 71.98%.
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2714      +/-   ##
==========================================
- Coverage   71.99%   71.98%   -0.01%     
==========================================
  Files         107      107              
  Lines       11914    11916       +2     
==========================================
+ Hits         8577     8578       +1     
- Misses       3337     3338       +1     
Files Coverage Δ
scanpy/_utils/__init__.py 65.64% <50.00%> (-0.10%) ⬇️

@glitchheadgit
Copy link
Author

glitchheadgit commented Oct 26, 2023

I think this pull request should be labeled as /label no milestone. Can someone take a look?

@flying-sheep
Copy link
Member

I think we should rather go with an existing decorator like https://github.com/tantale/deprecated

A PR should modify all deprecated functions and docstrings to rely on the decorator instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tell people they’re using deprecated functions
2 participants