Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc submodule #2901

Merged
merged 49 commits into from Mar 26, 2024
Merged

Doc submodule #2901

merged 49 commits into from Mar 26, 2024

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Mar 12, 2024

Overhaul of tutorials page

Tutorials can now be versioned with the docs by using a gitsubmodule of the tutorials repo (letting us avoid things like: scverse/scanpy-tutorials#85)

Possible additions, that can be left to later

  • It's a lot more bare now, maybe we should use cards? I wasn't sure if there's a great way to do this while keeping overall organization.
  • Some tutorials that have been removed may be worth keeping
    • 1.3 million mouse neurons
    • Cell cycle regression

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.49%. Comparing base (f5edd43) to head (b22084d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2901   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files         116      116           
  Lines       12911    12911           
=======================================
  Hits         9747     9747           
  Misses       3164     3164           
Files Coverage Δ
scanpy/datasets/_datasets.py 86.04% <ø> (ø)
scanpy/neighbors/__init__.py 80.75% <ø> (ø)
scanpy/plotting/_tools/scatterplots.py 86.48% <ø> (ø)
scanpy/tools/_ingest.py 77.23% <ø> (ø)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ivirshup ivirshup added this to the 1.10.0 milestone Mar 18, 2024
@ivirshup
Copy link
Member Author

@flying-sheep, docs are building now if you want to take a look

docs/tutorials/basics/clustering-2017.ipynb Outdated Show resolved Hide resolved
docs/_tutorials.md Outdated Show resolved Hide resolved
docs/references.bib Show resolved Hide resolved
docs/how-to/index.md Show resolved Hide resolved
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure looks good, two main things:

  1. The tutorial site looks a bit messy, with toc trees, paragraphs, and images interspersed. If you e.g. remove the sub-indices, put the text together and use a sphinx-design grid for the images, you’d get:

    grafik

  2. See Doc submodule #2901 (review)

    Bibtool should run either in CI or at least locally.

pyproject.toml Show resolved Hide resolved
docs/news.md Outdated Show resolved Hide resolved
docs/tutorials/basics/index.md Outdated Show resolved Hide resolved
@ivirshup
Copy link
Member Author

Seems like you accidentally force-pushed over my commits, please re-add:

This was intentional as those changes broke the doc build. sphinxcontrib-bibtex couldn't parse the reformatted bibtex file. Over here I requested that if you want to add bib tool working as a precommit, I would like you to do it in a separate branch.

pyproject.toml Outdated Show resolved Hide resolved
@flying-sheep
Copy link
Member

flying-sheep commented Mar 25, 2024

OK, now the only thing missing is to move the notebooks directory into docs and to make sure the bibtex isn’t a mess.

You said you don’t want to do that manually, so please add some way to do it automatically.

sphinxcontrib-bibtex couldn't parse the reformatted bibtex file.

hmm, so we can’t trust its parser to work properly, that’s a bit concerning. But we control what it sees so that isn’t too bad.

@ivirshup
Copy link
Member Author

OK, now the only thing missing is to move the notebooks directory into docs

We have already discussed this, and it is staying as is for now. We can think about doing this in the future, but please make your case in an issue.

bibtex isn’t a mess.

I will be leaving the bibtex as is, I don't see an issue with the bibtex as it renders fine. As I requested last week, you can suggest a formatter for it in a separate PR. Notably this bibtex is copied directly from scverse-tutorials, which doesn't seem to have caused any issues.

FWIW there are some tools for working with bibtex recommended here:

@ivirshup ivirshup merged commit 65f567e into main Mar 26, 2024
13 checks passed
@ivirshup ivirshup deleted the doc-submodule branch March 26, 2024 13:15
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Mar 26, 2024
ivirshup added a commit that referenced this pull request Mar 26, 2024
Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
@flying-sheep flying-sheep linked an issue Mar 26, 2024 that may be closed by this pull request
@flying-sheep flying-sheep mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go back to tutorial submodule
2 participants