New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc submodule #2901
Doc submodule #2901
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
=======================================
Coverage 75.49% 75.49%
=======================================
Files 116 116
Lines 12911 12911
=======================================
Hits 9747 9747
Misses 3164 3164
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@flying-sheep, docs are building now if you want to take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure looks good, two main things:
-
The tutorial site looks a bit messy, with toc trees, paragraphs, and images interspersed. If you e.g. remove the sub-indices, put the text together and use a sphinx-design grid for the images, you’d get:
-
See Doc submodule #2901 (review)
Bibtool should run either in CI or at least locally.
This was intentional as those changes broke the doc build. sphinxcontrib-bibtex couldn't parse the reformatted bibtex file. Over here I requested that if you want to add bib tool working as a precommit, I would like you to do it in a separate branch. |
OK, now the only thing missing is to move the notebooks directory into You said you don’t want to do that manually, so please add some way to do it automatically.
hmm, so we can’t trust its parser to work properly, that’s a bit concerning. But we control what it sees so that isn’t too bad. |
We have already discussed this, and it is staying as is for now. We can think about doing this in the future, but please make your case in an issue.
I will be leaving the bibtex as is, I don't see an issue with the bibtex as it renders fine. As I requested last week, you can suggest a formatter for it in a separate PR. Notably this bibtex is copied directly from scverse-tutorials, which doesn't seem to have caused any issues. FWIW there are some tools for working with bibtex recommended here:
|
Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
Overhaul of tutorials page
Tutorials can now be versioned with the docs by using a gitsubmodule of the tutorials repo (letting us avoid things like: scverse/scanpy-tutorials#85)
Possible additions, that can be left to later