Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale clips low #2913

Merged
merged 6 commits into from Mar 14, 2024
Merged

Scale clips low #2913

merged 6 commits into from Mar 14, 2024

Conversation

Intron7
Copy link
Member

@Intron7 Intron7 commented Mar 14, 2024

fixes #2912

@Intron7 Intron7 added this to the 1.10.0 milestone Mar 14, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 14, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (1fee6a1) to head (afaa6fe).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2913      +/-   ##
==========================================
- Coverage   74.82%   73.16%   -1.67%     
==========================================
  Files         116      116              
  Lines       12811    12776      -35     
==========================================
- Hits         9586     9347     -239     
- Misses       3225     3429     +204
Files Coverage Δ
scanpy/preprocessing/_simple.py 80.88% <100.00%> (-2.02%) ⬇️

... and 23 files with indirect coverage changes

flying-sheep
flying-sheep reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like only the zero_center path is hit during testing, weird. Would it be possible to test the other branch?

grafik

@Intron7
Copy link
Member Author

Intron7 commented Mar 14, 2024

That should solve it

flying-sheep
flying-sheep approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@flying-sheep flying-sheep enabled auto-merge (squash) March 14, 2024 11:21
@flying-sheep flying-sheep merged commit c6a7ae1 into main Mar 14, 2024
13 checks passed
@flying-sheep flying-sheep deleted the scale-clips-low branch March 14, 2024 12:02
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Mar 14, 2024
@Intron7 @meeseeksmachine
Backport PR scverse#2913: Scale clips low
4efa173
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 14, 2024
Merged
flying-sheep pushed a commit that referenced this pull request Mar 14, 2024
@meeseeksmachine @Intron7
Backport PR #2913 on branch 1.10.x (Scale clips low) (#2917)
6d22995 
Co-authored-by: Severin Dicks <37635888+Intron7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flying-sheep flying-sheep flying-sheep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

scale max value only cuts high values
2 participants
@Intron7 @flying-sheep