Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage job #2996

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Update coverage job #2996

merged 2 commits into from
Apr 11, 2024

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Apr 9, 2024

CI is bugging us to upgrade this

It's also saying we aren't uploading anything, and we already have another task for uploading...

I'm going to use this pr to

  1. try upgrading
  2. try removing

and seeing what the effects are.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.52%. Comparing base (10f4ebc) to head (ed228fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2996   +/-   ##
=======================================
  Coverage   75.52%   75.52%           
=======================================
  Files         117      117           
  Lines       12951    12951           
=======================================
  Hits         9781     9781           
  Misses       3170     3170           

@ivirshup
Copy link
Member Author

This actually seems to fix whatever the issue was so I'll go with it

@ivirshup ivirshup marked this pull request as ready for review April 10, 2024 15:09
@ivirshup ivirshup added this to the 1.10.2 milestone Apr 10, 2024
ivirshup added a commit to scverse/anndata that referenced this pull request Apr 10, 2024
ivirshup added a commit to scverse/anndata that referenced this pull request Apr 10, 2024
@ivirshup ivirshup merged commit 496bbb6 into scverse:main Apr 11, 2024
15 of 17 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Apr 11, 2024
ivirshup added a commit that referenced this pull request Apr 11, 2024
Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
flying-sheep pushed a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant