Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupwise data to obs #20

Closed
grst opened this issue Apr 9, 2020 · 9 comments
Closed

Add groupwise data to obs #20

grst opened this issue Apr 9, 2020 · 9 comments
Assignees
Milestone

Comments

@grst
Copy link
Collaborator

grst commented Apr 9, 2020

In GitLab by @szabogtamas on Feb 10, 2020, 13:00

When computing convergence, it seems plausible to add the convergence value (let us say log(1/singleton rate) for now) for a single cell given the grouping to obs and not only the singleton/duplicate/triplicate rates to uns.
The case would be similar with alpha diversity scores and maybe also clonal expansion.
If we add it, what rule should we follow for column names?

@grst grst added this to the plot overhaul milestone Apr 9, 2020
@grst grst self-assigned this Apr 9, 2020
@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Feb 11, 2020, 11:41

Sounds like a good idea to me. Then the data can easily be used to visualize it on a umap embedding also.

  • I guess column names shouldn't be too long, but long enough that it's clear what they contain.
  • Ideally, the column name can be customized using a function argument (I think it's called key_added in scanpy).
  • Data should not be duplicated (if uns contains summaries and obs a per-cell value it's ok, but if it would contain exactly the same information, it should only be stored in one of obs and uns.)

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 20, 2020, 18:12

For some of the computed metrics, this is definitely useful.
E.g. clonal expansion could also be nice to visualize on a umap plot.

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 20, 2020, 18:13

changed title from Add {-any of groupwise data to both uns and obs as well?-} to Add {+ groupwise data to obs+}

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 20, 2020, 18:13

assigned to @grst

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 30, 2020, 11:07

mentioned in commit 8ce1265

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 30, 2020, 11:20

closed via merge request !31

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 30, 2020, 11:20

closed via merge request !29

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 30, 2020, 11:20

mentioned in commit 28a1796

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 30, 2020, 11:20

closed via commit 8ce1265

@grst grst closed this as completed Apr 9, 2020
grst added a commit that referenced this issue Aug 23, 2020
Former-commit-id: 8186d5061e5d67f1f53281552f47da309a8787d5
grst added a commit that referenced this issue Aug 23, 2020
Improve tutorial

Closes #44 and #20

See merge request icbi-lab/pipelines/singlecell_tcr!29

Former-commit-id: b3f160194abd86189b6978f468dfc9766834d601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant