-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with dandelion #240
Conversation
Adjustment to allow for reading from pandas dataframe
add dandelion conversion wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments, I hope I'm not too nitpicky ;)
Eventually, we'll need to add tests for that as well, but you can also leave that to me.
Ah, and you'll need to run the black formatter as well. To set it up, run the following commands in the root of the repository pip install pre-commit
pre-commit install |
initial dict was placed in the wrong position in the for-loop
This is almost ready for review. I'm just trying to solve some bugs with my github actions on |
The docs complain about something with the type annotations... don't see how this would be related since no type annotations have changed in this PR. I'll finally dedicate some time to scirpy next week, but I would like to finish up #230 first, before I look into #241. |
Nope all good - take your time. |
This is now merged into #241. I'll keep you posted! |
Some initial code that should work with dandelion to convert between the two instances from zktuong/dandelion#49 onwards.
Still need to work in the extra bits on fully initialized scirpy and dandelion objects.