Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to sphinx book theme #1673

Merged
merged 50 commits into from Mar 1, 2023
Merged

Switch to sphinx book theme #1673

merged 50 commits into from Mar 1, 2023

Conversation

adamgayoso
Copy link
Member

@adamgayoso adamgayoso commented Sep 13, 2022

This aligns us with the scverse cookiecutter. The theme also now has dark mode.

One thing we need to change is to make the tutorial notebooks use myst-nb style admonitions.

The way the theme handles colab urls isn't compatible with how we use git submodules, so I created a simple sphinx extension to handle this and edit the colab url post hoc

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Patch and project coverage have no change.

Comparison is base (74e9890) 89.13% compared to head (e458270) 89.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1673   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files         142      142           
  Lines       11102    11102           
=======================================
  Hits         9896     9896           
  Misses       1206     1206           
Flag Coverage Δ
unittests 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamgayoso adamgayoso changed the title Switch from nbsphinx to myst-nb Switch to sphinx book theme Feb 13, 2023
@adamgayoso adamgayoso marked this pull request as ready for review March 1, 2023 21:37
@adamgayoso
Copy link
Member Author

@martinkim0 we can get this in but not backport it to 0.20.x, so it would come out at the next major release

Copy link
Contributor

@martinkim0 martinkim0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamgayoso adamgayoso enabled auto-merge (squash) March 1, 2023 22:12
@adamgayoso adamgayoso merged commit 948d44b into main Mar 1, 2023
@adamgayoso adamgayoso deleted the mystnb branch March 21, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants