New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to sphinx book theme #1673
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 142 142
Lines 11102 11102
=======================================
Hits 9896 9896
Misses 1206 1206
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
for more information, see https://pre-commit.ci
@martinkim0 we can get this in but not backport it to 0.20.x, so it would come out at the next major release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This aligns us with the scverse cookiecutter. The theme also now has dark mode.
One thing we need to change is to make the tutorial notebooks use myst-nb style admonitions.
The way the theme handles colab urls isn't compatible with how we use git submodules, so I created a simple sphinx extension to handle this and edit the colab url post hoc