Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize DataFrame and ArrayLike fields #1830

Merged
merged 4 commits into from Jan 5, 2023
Merged

Generalize DataFrame and ArrayLike fields #1830

merged 4 commits into from Jan 5, 2023

Conversation

martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented Jan 3, 2023

Opened in favor of #1821 with changes to retain previous git history.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 90.53% // Head: 90.44% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (0ef345c) compared to base (b7fb141).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
- Coverage   90.53%   90.44%   -0.09%     
==========================================
  Files         135      135              
  Lines       10587    10646      +59     
==========================================
+ Hits         9585     9629      +44     
- Misses       1002     1017      +15     
Impacted Files Coverage Δ
scvi/data/fields/_dataframe_field.py 94.11% <83.33%> (ø)
scvi/data/fields/_arraylike_field.py 92.95% <88.04%> (ø)
scvi/data/fields/__init__.py 100.00% <100.00%> (ø)
scvi/data/fields/_mudata.py 89.70% <100.00%> (ø)
scvi/data/fields/_protein.py 98.21% <100.00%> (ø)
scvi/data/fields/_scanvi.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@martinkim0 martinkim0 enabled auto-merge (squash) January 3, 2023 19:26
@martinkim0 martinkim0 added this to the 0.20.0 milestone Jan 4, 2023
@martinkim0 martinkim0 merged commit a2fa4e6 into main Jan 5, 2023
@martinkim0 martinkim0 deleted the martin/fields branch January 5, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants