Implement dev container for Codespaces #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportBase: 90.42% // Head: 90.42% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1836 +/- ##
=======================================
Coverage 90.42% 90.42%
=======================================
Files 142 142
Lines 11097 11097
=======================================
Hits 10034 10034
Misses 1063 1063 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added 2 commits
January 4, 2023 16:30
adamgayoso
approved these changes
Jan 9, 2023
adamgayoso
reviewed
Jan 9, 2023
.devcontainer/devcontainer.json
Outdated
| { | ||
| "name": "Python 3", | ||
| // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile | ||
| "image": "mcr.microsoft.com/devcontainers/python:0-3.8", |
There was a problem hiding this comment.
might want python 3.10 though
adamgayoso
reviewed
Jan 31, 2023
.devcontainer/Dockerfile
Outdated
| COPY . . | ||
|
|
||
| RUN pip install --upgrade pip | ||
| RUN pip install "https://storage.googleapis.com/jax-releases/nocuda/jaxlib-0.4.1-cp310-cp310-manylinux2014_x86_64.whl" |
There was a problem hiding this comment.
can you install mambaforge, mamba install scvi tools, then pip editable install?
adamgayoso
reviewed
Jan 31, 2023
.devcontainer/devcontainer.json
Outdated
| "extensions": [ | ||
| "EditorConfig.EditorConfig", | ||
| "ms-python.python", | ||
| "mhutchie.git-graph" |
There was a problem hiding this comment.
actually let's do git lens instead of git graph, as it comes with a graph
added 2 commits
January 31, 2023 13:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1835