Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lightning to >=1.9, bump other minimums, stage 0.20.0b1 #1863

Merged
merged 6 commits into from Jan 23, 2023

Conversation

adamgayoso
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Base: 90.39% // Head: 90.43% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (1fb4c6a) compared to base (5fe6c4d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1863      +/-   ##
==========================================
+ Coverage   90.39%   90.43%   +0.03%     
==========================================
  Files         141      141              
  Lines       11103    11095       -8     
==========================================
- Hits        10037    10034       -3     
+ Misses       1066     1061       -5     
Impacted Files Coverage Δ
scvi/__init__.py 100.00% <ø> (+12.50%) ⬆️
scvi/_settings.py 83.65% <100.00%> (ø)
scvi/train/_trainer.py 100.00% <100.00%> (ø)
scvi/data/_download.py 86.84% <0.00%> (-0.34%) ⬇️
scvi/module/_multivae.py 82.02% <0.00%> (+0.22%) ⬆️
scvi/module/_totalvae.py 88.14% <0.00%> (+0.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamgayoso adamgayoso enabled auto-merge (squash) January 21, 2023 22:55
@adamgayoso adamgayoso changed the title update lightning to >=1.9 update lightning to >=1.9, bump other minimums Jan 22, 2023
from ray import tune # noqa
except ImportError:
pass

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work now without this block?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was having no issues. Can you check as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm still having the issue unfortunately. I usually check by running

import scvi
import ray
ray.init()
ray.shutdown()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not having that issue and the tests are passing, I'm wondering what could be happening

@adamgayoso adamgayoso changed the title update lightning to >=1.9, bump other minimums update lightning to >=1.9, bump other minimums, stage 0.20.0b1 Jan 23, 2023
@adamgayoso adamgayoso merged commit 47bf4a5 into main Jan 23, 2023
@adamgayoso adamgayoso deleted the lightning_update branch January 23, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants