Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adversarial classifier #1980

Merged
merged 2 commits into from Mar 24, 2023
Merged

Fix adversarial classifier #1980

merged 2 commits into from Mar 24, 2023

Conversation

adamgayoso
Copy link
Member

  • Fixes reference of z in wrong scope

@adamgayoso adamgayoso marked this pull request as ready for review March 24, 2023 21:57
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (79160dc) 89.15% compared to head (c14858d) 89.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1980      +/-   ##
==========================================
- Coverage   89.15%   89.12%   -0.04%     
==========================================
  Files         141      141              
  Lines       11201    11205       +4     
==========================================
  Hits         9986     9986              
- Misses       1215     1219       +4     
Flag Coverage Δ
unittests 89.12% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scvi/train/_trainingplans.py 94.25% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@martinkim0 martinkim0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamgayoso adamgayoso merged commit 54b919f into main Mar 24, 2023
5 checks passed
@adamgayoso adamgayoso deleted the adversarial_fix branch March 24, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants