Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Literal compat class #2115

Merged
merged 2 commits into from Jun 28, 2023
Merged

Remove deprecated Literal compat class #2115

merged 2 commits into from Jun 28, 2023

Conversation

martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented Jun 28, 2023

  • Closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest docs/release_notes/index.md file if fixing a bug or adding a new feature.
  • If the changes are patches for a version, I have added the on-merge: backport to x.x.x label.

@martinkim0 martinkim0 added the on-merge: backport to 1.1.x on-merge: backport to 1.1.x label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6d9a29b) 88.58% compared to head (af0d1be) 88.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2115   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files         145      145           
  Lines       11743    11743           
=======================================
  Hits        10403    10403           
  Misses       1340     1340           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@martinkim0 martinkim0 merged commit 50b9bbe into main Jun 28, 2023
7 of 8 checks passed
@martinkim0 martinkim0 deleted the deprecated-literal branch June 28, 2023 19:02
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Jun 28, 2023
martinkim0 added a commit that referenced this pull request Jul 3, 2023
Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-merge: backport to 1.1.x on-merge: backport to 1.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant