Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate flax frozen dicts to dict #2222

Merged
merged 3 commits into from Aug 2, 2023
Merged

Migrate flax frozen dicts to dict #2222

merged 3 commits into from Aug 2, 2023

Conversation

martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented Aug 2, 2023

  • Closes Jax tests failing due to module init #2220 (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest docs/release_notes/index.md file if fixing a bug or adding a new feature.
  • If the changes are patches for a version, I have added the on-merge: backport to x.x.x label.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ac1743b) 89.10% compared to head (6237f46) 89.10%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2222   +/-   ##
=======================================
  Coverage   89.10%   89.10%           
=======================================
  Files         145      145           
  Lines       11809    11810    +1     
=======================================
+ Hits        10522    10523    +1     
  Misses       1287     1287           
Files Changed Coverage Δ
scvi/external/tangram/_model.py 91.74% <100.00%> (+0.07%) ⬆️
scvi/module/base/_base_module.py 94.25% <100.00%> (-0.03%) ⬇️
scvi/train/_callbacks.py 87.71% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinkim0 martinkim0 merged commit 9225a0f into main Aug 2, 2023
7 checks passed
@martinkim0 martinkim0 deleted the flax-migrate branch August 2, 2023 20:28
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Aug 2, 2023
martinkim0 added a commit that referenced this pull request Aug 2, 2023
Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jax tests failing due to module init
1 participant