Pass in n_hidden to Encoder in AmortizedLDA
#2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n_hidden was without effect in AmortizedLDA.
for more information, see https://pre-commit.ci
Added to release_notes.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2229 +/- ##
==========================================
- Coverage 89.10% 89.09% -0.01%
==========================================
Files 145 145
Lines 11810 11810
==========================================
- Hits 10523 10522 -1
- Misses 1287 1288 +1
☔ View full report in Codecov by Sentry. |
|
Walkthrough: This update introduces a new feature in the AmortizedLDA method where the Changes:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected for processing (2)
- docs/release_notes/index.md (1 hunks)
- scvi/module/_amortizedlda.py (1 hunks)
Files skipped from review due to trivial changes (2)
- docs/release_notes/index.md
- scvi/module/_amortizedlda.py
Review comments generated (0)
- Actionable : 0
- LGTM (Skipped): 0
- Noise Suppression (Skipped): 0
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Tag the bot with
@coderabbitaiin any review comment to ask it questions. The bot will not respond unless explicitly tagged. - A review comment is a comment on a diff or a file and not a comment on the PR itself.
- You can use the mouse to select multiple lines of code to provide exact context to the bot.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
Files selected for processing (1)
- docs/release_notes/index.md (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/release_notes/index.md
Review comments generated (0)
- Actionable : 0
- LGTM (Skipped): 0
- Noise Suppression (Skipped): 0
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Tag the bot with
@coderabbitaiin any review comment to ask it questions. The bot will not respond unless explicitly tagged. - A review comment is a comment on a diff or a file and not a comment on the PR itself.
- You can use the mouse to select multiple lines of code to provide exact context to the bot.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
martinkim0
changed the title
n_hidden to Encoder in AmortizedLDA
There was a problem hiding this comment.
Files selected for processing (1)
- docs/release_notes/index.md (2 hunks)
Review comments generated (0)
- Actionable : 0
- LGTM (Skipped): 2
- Noise Suppression (Skipped): 0
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Tag the bot with
@coderabbitaiin any review comment to ask it questions. The bot will not respond unless explicitly tagged. - A review comment is a comment on a diff or a file and not a comment on the PR itself.
- You can use the mouse to select multiple lines of code to provide exact context to the bot.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n_hidden was without effect in AmortizedLDA.
docs/release_notes/index.mdfile if fixing a bug or adding a new feature.on-merge: backport to x.x.xlabel.Summary by CodeRabbit
Release Notes:
n_hiddenparameter is now effective in theAmortizedLDAmodel. This enhancement allows users to specify the number of hidden layers in the model, providing more flexibility and control over the model's complexity.