Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revalidate devices when auto switching mps to cpu #2247

Merged
merged 3 commits into from Aug 18, 2023
Merged

Conversation

martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented Aug 18, 2023

  • Closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest docs/release_notes/index.md file if fixing a bug or adding a new feature.
  • If the changes are patches for a version, I have added the on-merge: backport to x.x.x label.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.02% ⚠️

Comparison is base (de59581) 89.10% compared to head (c6de73c) 89.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2247      +/-   ##
==========================================
- Coverage   89.10%   89.09%   -0.02%     
==========================================
  Files         145      145              
  Lines       11815    11817       +2     
==========================================
  Hits        10528    10528              
- Misses       1287     1289       +2     
Files Changed Coverage Δ
scvi/model/_utils.py 89.04% <40.00%> (-1.24%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinkim0 martinkim0 changed the title Passthrough auto device for cpu Revalidate devices when auto switching mps to cpu Aug 18, 2023
@martinkim0 martinkim0 merged commit 682a7f7 into main Aug 18, 2023
7 checks passed
@martinkim0 martinkim0 deleted the mps-device branch August 18, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant