Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AnnData 0.10.0 #2271

Merged
merged 6 commits into from Oct 9, 2023
Merged

Add support for AnnData 0.10.0 #2271

merged 6 commits into from Oct 9, 2023

Conversation

martinkim0
Copy link
Contributor

  • Closes Support for upcoming AnnData 0.10.0rc1 for compatibility with the latest rapids_singlecell #2268 (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest docs/release_notes/index.md file if fixing a bug or adding a new feature.
  • If the changes are patches for a version, I have added the on-merge: backport to x.x.x label.

@martinkim0
Copy link
Contributor Author

Blocked by scverse/mudata#59

@martinkim0 martinkim0 added this to the scvi-tools 1.1.0 milestone Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9bdf678) 89.10% compared to head (e2eac78) 89.11%.

❗ Current head e2eac78 differs from pull request most recent head 939838b. Consider uploading reports for the commit 939838b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2271   +/-   ##
=======================================
  Coverage   89.10%   89.11%           
=======================================
  Files         145      145           
  Lines       11822    11828    +6     
=======================================
+ Hits        10534    10540    +6     
  Misses       1288     1288           
Files Coverage Δ
scvi/data/_anntorchdataset.py 96.00% <100.00%> (+0.16%) ⬆️
scvi/data/_utils.py 94.07% <100.00%> (+0.11%) ⬆️
scvi/model/base/_archesmixin.py 93.93% <100.00%> (ø)
scvi/data/_built_in_data/_synthetic.py 84.90% <33.33%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinkim0 martinkim0 enabled auto-merge (squash) October 9, 2023 22:01
@martinkim0 martinkim0 merged commit 3fc7a1f into main Oct 9, 2023
5 of 6 checks passed
@martinkim0 martinkim0 deleted the anndata-prerelease branch October 9, 2023 22:02
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 9, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 3fc7a1fca702ff3ace1bd1366f3b8e10e59c3a5e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #2271: Add support for AnnData 0.10.0'
  1. Push to a named branch:
git push YOURFORK 1.0.x:auto-backport-of-pr-2271-on-1.0.x
  1. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #2271 on branch 1.0.x (Add support for AnnData 0.10.0)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant