Fix repr for custom distributions, add optional constraint #2395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2392
NegativeBinomial
andZeroInflatedNegativeBinomial
would raise an ambiguousValueError
when the following conditions were met:scale
not passed in and thus defaulted toNone
log_prob
called on a tensor not within supportThis caused an error on this line when calling
__repr__
sinceself.scale
evaluated toNone
.Another issue was that
validate_args
could not beTrue
when any optional parameters are left asNone
. Fixed with an optional constraint wrapper.