Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chex dependency #2482

Merged
merged 2 commits into from Feb 7, 2024
Merged

Remove chex dependency #2482

merged 2 commits into from Feb 7, 2024

Conversation

martinkim0
Copy link
Contributor

No description provided.

@martinkim0 martinkim0 added the on-merge: backport to 1.1.x on-merge: backport to 1.1.x label Feb 7, 2024
@martinkim0 martinkim0 merged commit 7f66909 into main Feb 7, 2024
11 of 12 checks passed
@martinkim0 martinkim0 deleted the remove-chex branch February 7, 2024 22:49
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Feb 7, 2024
martinkim0 added a commit that referenced this pull request Feb 7, 2024
Backport PR #2482: Remove chex dependency

Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
@martinkim0
Copy link
Contributor Author

meeseeksdev backport to 1.0.x

Copy link

lumberbot-app bot commented Feb 12, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 7f669091002595f51674ae9c2ffe49348ef56e8d
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #2482: Remove chex dependency'
  1. Push to a named branch:
git push YOURFORK 1.0.x:auto-backport-of-pr-2482-on-1.0.x
  1. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #2482 on branch 1.0.x (Remove chex dependency)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-merge: backport to 1.1.x on-merge: backport to 1.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant