Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add option to generate synthetic coords #2603

Merged
merged 4 commits into from Mar 6, 2024
Merged

[feat] add option to generate synthetic coords #2603

merged 4 commits into from Mar 6, 2024

Conversation

martinkim0
Copy link
Contributor

No description provided.

@martinkim0 martinkim0 added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Mar 6, 2024
@martinkim0 martinkim0 requested a review from LevyNat March 6, 2024 17:07
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (485e289) to head (4715007).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
- Coverage   89.84%   89.38%   -0.47%     
==========================================
  Files         154      154              
  Lines       12617    12621       +4     
==========================================
- Hits        11336    11281      -55     
- Misses       1281     1340      +59
Files Coverage Δ
scvi/data/_built_in_data/_synthetic.py 100.00% <100.00%> (+15.09%) ⬆️
scvi/data/_datasets.py 84.21% <ø> (ø)

... and 2 files with indirect coverage changes

@martinkim0 martinkim0 merged commit 589eb38 into main Mar 6, 2024
10 checks passed
@martinkim0 martinkim0 deleted the synthetic-coordinates branch March 6, 2024 18:33
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Mar 6, 2024
@martinkim0 @meeseeksmachine
Backport PR scverse#2603: [feat] add option to generate synthetic coords
8c4c4c3
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 6, 2024
Merged
martinkim0 added a commit that referenced this pull request Mar 6, 2024
@meeseeksmachine @martinkim0
Backport PR #2603 on branch 1.2.x ([feat] add option to generate synt…
994363a 
…hetic coords) (#2604)

Backport PR #2603: [feat] add option to generate synthetic coords

Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
@martinkim0 martinkim0 mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LevyNat LevyNat LevyNat approved these changes

Assignees
No one assigned
Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinkim0 @LevyNat