Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hub): add unsigned arg to hubmodel s3 pull #2615

Merged
merged 2 commits into from Mar 19, 2024
Merged

feat(hub): add unsigned arg to hubmodel s3 pull #2615

merged 2 commits into from Mar 19, 2024

Conversation

martinkim0
Copy link
Contributor

feature only added to pull_from_s3 as users should authenticate if pushing to a bucket

@martinkim0 martinkim0 added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Mar 17, 2024
@martinkim0 martinkim0 added the private tests Run private tests label Mar 17, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 17, 2024 •
edited

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.18%. Comparing base (6ea4bf9) to head (21b987c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2615      +/-   ##
==========================================
- Coverage   89.21%   89.18%   -0.03%     
==========================================
  Files         159      159              
  Lines       13306    13309       +3     
==========================================
- Hits        11871    11870       -1     
- Misses       1435     1439       +4
Files Coverage Δ
scvi/hub/_model.py 94.56% <66.66%> (-0.47%) ⬇️

... and 1 file with indirect coverage changes

@martinkim0 martinkim0 changed the title feat: add unsigned arg to hubmodel s3 pull feat(hub): add unsigned arg to hubmodel s3 pull Mar 19, 2024
@martinkim0 martinkim0 merged commit f53c01a into main Mar 19, 2024
13 checks passed
@martinkim0 martinkim0 deleted the aws-unsigned branch March 19, 2024 17:21
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Mar 19, 2024
@martinkim0 @meeseeksmachine
Backport PR scverse#2615: feat(hub): add unsigned arg to hubmodel s3 …
5365fec 
…pull
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 19, 2024
Merged
martinkim0 added a commit that referenced this pull request Mar 19, 2024
@meeseeksmachine @martinkim0
Backport PR #2615 on branch 1.2.x (feat(hub): add unsigned arg to hub…
32ddf04 
…model s3 pull) (#2617)

Backport PR #2615: feat(hub): add unsigned arg to hubmodel s3 pull

Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canergen canergen Awaiting requested review from canergen

Assignees
No one assigned
Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x private tests Run private tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@martinkim0