New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(model): support batch key in condscvi #2626
Conversation
@canergen The main backwards compatibility concern right now is that, with the current There's not a straightforward way to distinguish this case from the case where a This is because a There are two potential ways to address this:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2626 +/- ##
==========================================
- Coverage 89.18% 88.68% -0.51%
==========================================
Files 159 159
Lines 13308 13306 -2
==========================================
- Hits 11869 11800 -69
- Misses 1439 1506 +67
|
adds a basic `CondSCVI` save file for backwards compatibility testing in #2626. generated as follows: ``` adata = synthetic_iid() CondSCVI.setup_anndata(adata, "labels") model = CondSCVI(adata) model.train(max_epochs=1) model.save(".../tests/test_data/condscvi_pre_batch") ```
@canergen Here's an initial exploration with using the batch key. TLDR Seems fine but can lead to overintegration when training for too long. |
We have quite some different datasets to see better integration. You need to run one UMAP per coarse celltype above. I don't think those are necessary but I requested only support to get the key into DestVI :). |
closes #2623