chore(module): remove unused code paths in scanvae loss #2644
Conversation
| @@ -323,32 +320,6 @@ def loss( | |||
| else: | |||
| kl_divergence_l = 0.0 | |||
|
|
|||
| if is_labelled: | |||
There was a problem hiding this comment.
feed_labels is always False => y is always None => is_labelled is always False
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2644 +/- ##
==========================================
+ Coverage 88.78% 88.83% +0.05%
==========================================
Files 158 158
Lines 13245 13234 -11
==========================================
- Hits 11759 11756 -3
+ Misses 1486 1478 -8
|
| y = None | ||
| is_labelled = False if y is None else True | ||
|
|
||
| # Enumerate choices of label | ||
| ys, z1s = broadcast_labels(y, z1, n_broadcast=self.n_labels) |
There was a problem hiding this comment.
could probably clean up this function call since y is always None - it would help with debugging and addressing #2429
|
per our discussion in slack @canergen |
|
sanity check with the Atlas-level integration of lung data tutorial: |
|
LGTM! Would an old model still load? I guess so as all of these feed_labels are created dynamically. Otherwise, we need to update the scvi-hub scANVI models. |
|
Not sure it's breaking in this case as it was never active. |
|
Yeah I think it should be backwards compatible - we have tests for old scanvi loads. |
BREAKING CHANGE: removes unused code paths in the loss method of SCANVAE due to the default being
feed_labels=False. internal functions that call this method either have their own default set tofeed_labels=Falseor havefeed_labels=Truebut don't pass it into the loss method (e.g. compute_elbo).also adds typing within the modified file.
closes #2134