Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(train): remove metrics callback and additional_val_metrics #2646

Merged
merged 5 commits into from Apr 2, 2024
Merged

chore(train): remove metrics callback and additional_val_metrics #2646

merged 5 commits into from Apr 2, 2024

Conversation

martinkim0
Copy link
Contributor

No description provided.

@martinkim0 martinkim0 added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Apr 2, 2024
@martinkim0 martinkim0 mentioned this pull request Apr 2, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (049e7eb) to head (ce8eb20).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2646      +/-   ##
==========================================
- Coverage   89.33%   88.78%   -0.56%     
==========================================
  Files         158      158              
  Lines       13276    13247      -29     
==========================================
- Hits        11860    11761      -99     
- Misses       1416     1486      +70
Files Coverage Δ
scvi/train/_callbacks.py 85.15% <ø> (-2.43%) ⬇️
scvi/train/_trainer.py 100.00% <ø> (ø)
scvi/train/_trainrunner.py 96.61% <100.00%> (ø)

... and 3 files with indirect coverage changes

@martinkim0 martinkim0 merged commit 561b601 into main Apr 2, 2024
10 checks passed
@martinkim0 martinkim0 deleted the remove-metrics branch April 2, 2024 19:56
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Apr 2, 2024
@martinkim0 @meeseeksmachine
Backport PR scverse#2646: chore(train): remove metrics callback and a…
12cdf1d 
…dditional_val_metrics
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 2, 2024
Merged
martinkim0 added a commit that referenced this pull request Apr 2, 2024
@meeseeksmachine @martinkim0
Backport PR #2646 on branch 1.2.x (chore(train): remove metrics callb…
8a30ad8 
…ack and additional_val_metrics) (#2647)

Backport PR #2646: chore(train): remove metrics callback and
additional_val_metrics

Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@martinkim0