Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(train): add load_best_on_end argument to save checkpoint #2672

Merged
merged 3 commits into from Apr 3, 2024

Conversation

martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented Apr 3, 2024

with this feature, the save checkpoint callback is feature-complete w.r.t. the current savebeststate callback.

needed before addressing #2568

@martinkim0 martinkim0 added on-merge: backport to 1.2.x on-merge: backport to 1.2.x cuda tests Run test suite on CUDA labels Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (85540d1) to head (aaac7c4).
Report is 1 commits behind head on main.

❗ Current head aaac7c4 differs from pull request most recent head 2c496e5. Consider uploading reports for the commit 2c496e5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2672   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files         158      158           
  Lines       13235    13242    +7     
=======================================
+ Hits        11757    11764    +7     
  Misses       1478     1478           
Files Coverage Δ
scvi/train/_callbacks.py 85.92% <100.00%> (+0.76%) ⬆️

@martinkim0 martinkim0 merged commit c1938c6 into main Apr 3, 2024
9 of 12 checks passed
@martinkim0 martinkim0 deleted the savebeststate branch April 3, 2024 01:41
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Apr 3, 2024
martinkim0 added a commit that referenced this pull request Apr 3, 2024
…argument to save checkpoint) (#2675)

Backport PR #2672: feat(train): add load_best_on_end argument to save
checkpoint

Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda tests Run test suite on CUDA on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant