Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename data_module to datamodule #2749

Merged
merged 1 commit into from Apr 23, 2024
Merged

refactor: rename data_module to datamodule #2749

merged 1 commit into from Apr 23, 2024

Conversation

martinkim0
Copy link
Contributor

@martinkim0 martinkim0 commented Apr 23, 2024 •
edited

BREAKING CHANGE: renames data_module argument to datamodule in train methods.

@martinkim0 martinkim0 added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Apr 23, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.90%. Comparing base (566b216) to head (79273ce).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2749      +/-   ##
==========================================
- Coverage   88.92%   88.90%   -0.03%     
==========================================
  Files         161      161              
  Lines       13318    13318              
==========================================
- Hits        11843    11840       -3     
- Misses       1475     1478       +3
Files Coverage Δ
src/scvi/model/base/_training_mixin.py 100.00% <100.00%> (ø)
src/scvi/autotune/_experiment.py 89.38% <0.00%> (ø)

... and 1 file with indirect coverage changes

@martinkim0 martinkim0 merged commit 5b435d4 into main Apr 23, 2024
13 of 15 checks passed
@martinkim0 martinkim0 deleted the rename branch April 23, 2024 21:49
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Apr 23, 2024
@martinkim0 @meeseeksmachine
Backport PR scverse#2749: refactor: rename data_module to datamodule
5060543
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 23, 2024
Merged
martinkim0 added a commit that referenced this pull request Apr 23, 2024
@meeseeksmachine @martinkim0
Backport PR #2749 on branch 1.2.x (refactor: rename data_module to da…
3d24826 
…tamodule) (#2750)

Backport PR #2749: refactor: rename data_module to datamodule

Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@martinkim0