docs(external): add typing and docstrings for mrvi, remove laplace scaling #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkim0
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mrvi #2757 +/- ##
==========================================
+ Coverage 89.10% 89.14% +0.04%
==========================================
Files 167 167
Lines 14242 14232 -10
==========================================
- Hits 12690 12687 -3
+ Misses 1552 1545 -7
|
martinkim0
commented
Apr 29, 2024
martinkim0
commented
Apr 29, 2024
justjhong
reviewed
Apr 30, 2024
|
Thanks @justjhong! Just removed instances of laplace and As in the code. |
martinkim0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.