-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace statsmodels with scipy stats #2762
Conversation
Tests are currently failing because |
@martinkim0 good catch, looks like statsmodels would just output nans. This happens when the input to chi2.cdf is 0 (which usually shouldn't happen - happens here since its barely training I assume), but we can still correctly handle this case by making the pval 1 for these examples. |
Awesome, thanks for pushing the changes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mrvi #2762 +/- ##
=======================================
Coverage 89.14% 89.14%
=======================================
Files 167 167
Lines 14232 14232
=======================================
Hits 12687 12687
Misses 1545 1545
|
No description provided.