feat(autotune): add support for ray 2.24 #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2831 +/- ##
==========================================
- Coverage 85.24% 85.22% -0.03%
==========================================
Files 166 166
Lines 14236 14236
==========================================
- Hits 12136 12133 -3
- Misses 2100 2103 +3
|
meeseeksmachine
pushed a commit
to meeseeksmachine/scvi-tools
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ray 2.24 apparently removed the local_dir argument from RunConfig, which should now be equivalent to storage_path (we were specifying both arguments as settings.logging_dir before). this commit just removes the local_dir argument on our end from autotune.Experiment.
see https://github.com/scverse/scvi-tools/actions/runs/9435814911/job/25989750995 for an example failure.