Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs #4

Merged
merged 13 commits into from
Dec 18, 2022
Merged

docs #4

merged 13 commits into from
Dec 18, 2022

Conversation

giovp
Copy link
Member

@giovp giovp commented Dec 18, 2022

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@giovp giovp changed the title add mypy as pre-commit docs Dec 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@55ca02d). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   18.93%           
=======================================
  Files           ?        5           
  Lines           ?      301           
  Branches        ?        0           
=======================================
  Hits            ?       57           
  Misses          ?      244           
  Partials        ?        0           
Flag Coverage Δ
unittests 18.93% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@giovp
Copy link
Member Author

giovp commented Dec 18, 2022

interestingly tests fail due to possibly python/cpython#83860
will try to fix upstream in spatialdata but it might be a good idea to drop support for 3.8 ?

@giovp giovp merged commit a4cdb70 into main Dec 18, 2022
@giovp giovp deleted the docs/start branch December 18, 2022 14:33
@timtreis timtreis mentioned this pull request Jan 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants