Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass plot notebooks #91

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Conversation

melonora
Copy link
Collaborator

@melonora melonora commented Apr 1, 2024

PR fixing all plots for the notebooks

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@melonora melonora marked this pull request as ready for review April 2, 2024 09:06
@melonora
Copy link
Collaborator Author

melonora commented Apr 2, 2024

The plots are all fixed as far as I can tell right now. Here and there there are issues with spatialdata-plot for which I have opened issues. Some that I will address still.

For squidpy there is only the question what the intent was for the cell in which it is stated that currently multi-table is broken.

@giovp
Copy link
Member

giovp commented Apr 3, 2024

looks great @melonora ! from the reviewNB it seems like the output were not visible, but from the built docs they are! so I think we are good to go, LGTM!

FYI: I'm doing the xenium use case off #93 and once done will ask for review and then merge #93 and the xenium one

@melonora
Copy link
Collaborator Author

melonora commented Apr 3, 2024

Great, I'll be available for review.

@LucaMarconato
Copy link
Member

Thanks, I rendered the figures (except for the mibitof notebook, which is not working as reported in spatialdata-plot). Merging!

@LucaMarconato LucaMarconato merged commit 4ddd338 into scverse:main Apr 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants