Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl_options is broken on Python3.12 #284

Open
fruch opened this issue Jan 5, 2024 · 4 comments
Open

ssl_options is broken on Python3.12 #284

fruch opened this issue Jan 5, 2024 · 4 comments
Assignees
@sylwiaszunejko
Labels
bug Something isn't working upstream-issue Issue is not specific to our fork and Scylla and should be also fixed in the upstream

Comments

@fruch
Copy link

fruch commented Jan 5, 2024

This older style of no using ssl context, is broken on 3.26.4

Seems like it's was mostly addressed already in up stream:

datastax#1191

Maybe we should deprecated completely at our end ?
Or just sync with 3.29.0 to get it ?
@fruch
Copy link
Author

fruch commented Jan 17, 2024

@avelanarius @Lorak-mmk, are we planning syncing with upstream 3.29.0, any time soon ?

or we'll need to backport the fix for this one manually ?

@avelanarius
Copy link

Is this issue urgent to fix?

I'd rather plan syncing with upstream to the next sprint (~start of February) since we already have a lot of stuff planned around Rust Driver.

@fruch
Copy link
Author

fruch commented Jan 17, 2024

Is this issue urgent to fix?

I'd rather plan syncing with upstream to the next sprint (~start of February) since we already have a lot of stuff planned around Rust Driver.

I can't tell exactly who is using ssl_options, but if they gonna move into python 3.12, it would stop working...

I've hit it in dtest in few tests, that wasn't using ssl_context, but I don't have anymore information beyond that

I've fixed the dtest to stop using it, so I can move to python 3.12

@fruch
Copy link
Author

fruch commented Jan 17, 2024

at least scylla tests are using only ssl_context
https://github.com/search?q=repo%3Ascylladb%2Fscylladb+ssl_context&type=code

@fruch fruch mentioned this issue Jan 17, 2024
Open
juliayakovlev added a commit to juliayakovlev/scylla-cluster-tests that referenced this issue Jan 25, 2024
@juliayakovlev
fix(python driver): use 'ssl_context' instead 'ssl_options'
2e7a639 
SCT python driver is using ssl_options when create session and should be switching to use
ssl_context since ssl_options is deprecated (and also broken for scylla-driver==3.26.4 ontop
python 3.12)

Refs: scylladb/python-driver#284
juliayakovlev added a commit to juliayakovlev/scylla-cluster-tests that referenced this issue Jan 25, 2024
@juliayakovlev
fix(python driver): use 'ssl_context' instead 'ssl_options'
957af23 
SCT python driver is using ssl_options when create session and should be switching to use
ssl_context since ssl_options is deprecated (and also broken for scylla-driver==3.26.4 ontop
python 3.12)

Refs: scylladb/python-driver#284
@juliayakovlev juliayakovlev mentioned this issue Jan 25, 2024
Merged
4 tasks
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this issue Jan 25, 2024
@juliayakovlev @fruch
fix(python driver): use 'ssl_context' instead 'ssl_options'
62df88f 
SCT python driver is using ssl_options when create session and should be switching to use
ssl_context since ssl_options is deprecated (and also broken for scylla-driver==3.26.4 ontop
python 3.12)

Refs: scylladb/python-driver#284
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this issue Jan 25, 2024
@juliayakovlev @fruch
fix(python driver): use 'ssl_context' instead 'ssl_options'
33f1782 
SCT python driver is using ssl_options when create session and should be switching to use
ssl_context since ssl_options is deprecated (and also broken for scylla-driver==3.26.4 ontop
python 3.12)

Refs: scylladb/python-driver#284
(cherry picked from commit 62df88f)
@avelanarius avelanarius assigned sylwiaszunejko and unassigned fruch and Lorak-mmk Feb 20, 2024
@Lorak-mmk Lorak-mmk added bug Something isn't working upstream-issue Issue is not specific to our fork and Scylla and should be also fixed in the upstream labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sylwiaszunejko sylwiaszunejko

Labels
bug Something isn't working upstream-issue Issue is not specific to our fork and Scylla and should be also fixed in the upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fruch @Lorak-mmk @avelanarius @sylwiaszunejko