scylla role: support for 2022.2 (5.1) #232

tarzanek · 2023-03-03T10:08:04Z

2022.1 and 5.0 should be supported too

tarzanek · 2023-03-03T10:10:59Z

I have only local tests on a sample VM done
I will need to run at least GCP test

We might in next PR upgrade molecule to cover the matrix (and do at least supported versions tests on Ubuntu)

tarzanek · 2023-03-06T10:01:04Z

tested internally on training: http://localhost:8081/job/Test/job/Lubos2/job/Ops/job/Create_cluster/4/console

mykaul · 2023-03-14T11:43:22Z

ansible-scylla-node/tasks/Debian_install.yml

+        # Let's filter by the arch first and then cut the version column.
+        # Then we will filter out all rows that start with a requested version string followed by a digit to filter out version like 2021.1.11 when 2021.1.1 was requested.
+        # And finally, we are going to get rid of duplications.
+        shell: apt list -a {{ scylla_package_prefix }}-machine-image 2>/dev/null | awk '{split($0,a," "); print a[2]}' | egrep "^{{ stripped_scylla_machine_image_version_escaped }}" | sort | uniq


Can we use 'apt info' or even 'apt-show-versions' ?

apt-show-versions is not installed by default, so it would create a dependency, so we should rather stick to the clumsy way above

apt info won't list all package versions, resp. I don't see how to force it to list all versions

okay,

apt info -a scylla-enterprise | grep Version

could likely work too

Can we use 'apt info' or even 'apt-show-versions' ?

Why? What advantage would it give us exactly?

apt info -a scylla-enterprise | grep Version
could likely work too

apt info -a scylla-enterprise doesn't have a platform information and nothing guarantees that you will always have same versions for all platforms.

tarzanek · 2023-03-30T11:17:10Z

@vladzcloudius @igorribeiroduarte can you also have a look?

tarzanek · 2023-03-30T11:18:55Z

rebased to last master (with Igors io properties fixes)

vladzcloudius

Lubos, please, write a much more detailed PR description and the description of every patch I asked to split this patch into.

ansible-scylla-node/meta/main.yml

vladzcloudius · 2023-03-31T18:28:22Z

ansible-scylla-node/tasks/Debian_install.yml

          file:
            state: absent
-            path: /etc/apt/preferences.d/99-scylla
+            path: "/etc/apt/preferences.d/99-{{ scylla_package_prefix }}"


This is not a 2022.2-spefic code.
Please, add a more detailed explanation what this patch is about.
But even before that it seems like this patch can and should be split into a few patches.

I have to mix this unfortunately, since I am using those blocks that used to install other versions to install scylla-image package

What about a better description?

In this patch you're making the install tasks more generic (which is not necessarily related to 2022.2) and also applying the changes related to `scyla-image' package (I/O settings and the installation itself), so I think it makes sense to divide this patch into at least two.

ansible-scylla-node/tasks/Debian_install.yml

vladzcloudius · 2023-03-31T19:37:02Z

ansible-scylla-node/tasks/Debian_install.yml

+# scylla machine image:
+# 2022.2.0-20230112.1239c34-1
+
+      - name: Get versions of {{ scylla_edition }} machine image package


This whole hunk is a copy-paste of a similar block between lines 31-38 in the same file. This asks for making an external 'task' of it and calling it for different package names.

well, partially, this code has different version parsing
scylla machine image doesn't follow same versioning as Scylla :-(
I will try to generalize as much of this as possible into single task

ansible-scylla-node/tasks/common.yml

tarzanek · 2023-06-02T09:19:17Z

2022.x switched to use a -o discard mount option instead of periodic fstrim
scylladb/scylladb@a19d00e
(older 4.19 kernels work better with fstrim, discard might work well only for latest kernels, but its perf impact might be for all operations! (while trim can be scheduled off peak))

note that upon upgrade fstrim was disabled (but discard wasn't enabled!), we should still be able to keep old setup and add support for discard at the same time

tarzanek · 2023-06-26T12:34:48Z

5.2 also deperecates bootparam script : scylladb/scylladb@9acdd3a

note that clock source needs to come from machine image pkg too:

https://github.com/scylladb/scylla-enterprise/commit/c2ccdac2975bcb841db96e7165a93e0b0f481b19

tarzanek · 2023-08-01T14:05:59Z

bootparam fixed in #276

tarzanek · 2023-08-03T08:16:18Z

addressed the comments, reformatted to new patches

I still need to retest RHEL (so don't merge until I clear my RHEL test)

tarzanek · 2023-08-03T15:32:59Z

retested on Centos 7, worked with workaround for

[centos7@centos7 ~]$ sudo /opt/scylladb/scripts/scylla_selinux_setup
Traceback (most recent call last):
  File "/opt/scylladb/scripts/libexec/scylla_selinux_setup", line 13, in <module>
    from scylla_util import *
  File "/opt/scylladb/scripts/scylla_util.py", line 25, in <module>
    import traceback_with_variables
ModuleNotFoundError: No module named 'traceback_with_variables'

(I basically commented out that module in /opt/scylladb/scripts/scylla_util.py , not sure if this is a bug, 2022 shouldn't really support Centos 7, shall it? ... it shall I checked https://www.scylladb.com/customer-portal/?product=ent&platform=centos&version=stable-release-2022.2 and we should support Centos 7.2 and above, I tested above on Centos 7.7)

tarzanek · 2023-08-04T08:23:24Z

ok, after adding molecule for 5.2 it seems I can reproduce the signing key for repo gpg error (likely the same as in #269 )
solution is to add support for instructions from https://www.scylladb.com/download/?platform=ubuntu-20.04&version=scylla-5.2#open-source to 5.2 or 2023

ansible-scylla-node/tasks/common.yml

igorribeiroduarte · 2023-08-04T17:09:41Z

ansible-scylla-node/tasks/common.yml

+      become: true
+# if above is not found leverage /opt/scylladb/python3/bin/python3 /opt/scylladb/scylla-machine-image/lib/scylla_cloud_io_setup.py ?
+# or provide our own role runner for pre 2022.2.1 ?
+      when: (io_cloud_setup.stat.exists) and (io_prop_cloud_stat.stat.exists|bool == False) and (present_scylla_disks.stdout|int > 0)


Why have you added this present_scylla_disks.stdout|int > 0 check only for cloud?
If you want to add this check, I think it should probably come in the beginning of this block and the role should fail in case the number of disks is 0

so the role should work also for situations where you have EBS disk or custom disk or just have everything on root disk
the tuning for various cloud providers should kick in ONLY when there is a raid, resp. /var/lib/scylla mount point (they check for that and won't proceed, so we cannot run that tuning for unsupported setups and have to continue with fallback to iotune - which is DEFAULT way of handling things in 2022 / 5.1)

hence this check is added, I should retest with scenario where you have EBS mounted - I have a bad feeling recent fixes by @syuu1228 will be confused by the fact that EBS volumes can now look like NVME disks ...
( https://github.com/scylladb/scylla-machine-image/blob/master/common/scylla_cloud_io_setup#L238 )
in such case you would get out of box a tuning for local nvme for networked EBS ...

thanks for pointing this out @igorribeiroduarte , this might be a regression in comparison to new GP3 EBS mounts in AWS which in devtree of kernel look like nvmes !

vladzcloudius · 2023-08-04T17:12:17Z

ansible-scylla-node/tasks/common.yml

+        /opt/scylladb/scylla-machine-image/scylla_cloud_io_setup
+      become: true
+# if above is not found leverage /opt/scylladb/python3/bin/python3 /opt/scylladb/scylla-machine-image/lib/scylla_cloud_io_setup.py ?
+# or provide our own role runner for pre 2022.2.1 ?


What is this comment about as well?
Let's not have personal notes in the code.

vladzcloudius

There are still a lot of comments.

2022 node exporter now works for clean install and upgrades fix detection of node-exporter services make sure the name of node exporter service matches the check

tarzanek · 2023-08-07T11:08:19Z

while testing I realized we would need to pin this machine image file too if we won't go for latest

tarzanek · 2023-08-07T15:37:18Z

2 tasks:

find version and package (either using hash(for scylla, consider customer builds), or not (for machine package))
do the pinning for 1)

tarzanek · 2023-08-07T15:50:43Z

version of machine image should be a variable - it should be defaulting to scylla version until first "-"
and of course can be overriden in params

tarzanek requested review from vladzcloudius and igorribeiroduarte March 3, 2023 10:08

tarzanek force-pushed the 2022.2 branch from 4e4c1d8 to d56283b Compare March 6, 2023 08:53

mykaul reviewed Mar 14, 2023

View reviewed changes

tarzanek force-pushed the 2022.2 branch from d56283b to d6e5a5c Compare March 30, 2023 11:18

tarzanek mentioned this pull request Mar 31, 2023

scylla 2022 upgrade, monitoring 4.0, manager 3.0 #153

Open

vladzcloudius requested changes Mar 31, 2023

View reviewed changes

tarzanek force-pushed the 2022.2 branch from d6e5a5c to 19be0fe Compare August 3, 2023 08:15

tarzanek force-pushed the 2022.2 branch 2 times, most recently from 56b3033 to 2f7a249 Compare August 3, 2023 15:30

tarzanek mentioned this pull request Aug 4, 2023

Compatibility with Scylla 5.2 #269

Open

tarzanek force-pushed the 2022.2 branch 2 times, most recently from a6d955b to 0eb7f04 Compare August 4, 2023 12:16

igorribeiroduarte reviewed Aug 4, 2023

View reviewed changes

ansible-scylla-node/tasks/common.yml Outdated Show resolved Hide resolved

vladzcloudius requested changes Aug 4, 2023

View reviewed changes

ansible-scylla-node/tasks/common.yml Show resolved Hide resolved

igorribeiroduarte reviewed Aug 4, 2023

View reviewed changes

vladzcloudius reviewed Aug 4, 2023

View reviewed changes

vladzcloudius requested changes Aug 4, 2023

View reviewed changes

tarzanek added 2 commits August 7, 2023 09:49

scylla-node: remove ignore_errors, make node exporter from 2022 work

6f732de

2022 node exporter now works for clean install and upgrades fix detection of node-exporter services make sure the name of node exporter service matches the check

scylla-node: be more clear why there is no match for scylla version

02d27fd

tarzanek added 2 commits August 7, 2023 09:49

scylla-node: support new machine image and its tuning

ddafedc

scylla-node: molecule tests for 2022.1, 2022.2

7e403d2

tarzanek force-pushed the 2022.2 branch from 0eb7f04 to 7e403d2 Compare August 7, 2023 07:50

tarzanek mentioned this pull request Jan 8, 2024

scylla-node: remove ignore_errors, make node exporter from 2022 work #324

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scylla role: support for 2022.2 (5.1) #232

scylla role: support for 2022.2 (5.1) #232

tarzanek commented Mar 3, 2023

tarzanek commented Mar 3, 2023

tarzanek commented Mar 6, 2023

mykaul Mar 14, 2023

tarzanek Mar 30, 2023 •

edited

Loading

tarzanek Mar 30, 2023

tarzanek Mar 30, 2023

vladzcloudius Mar 31, 2023

tarzanek commented Mar 30, 2023

tarzanek commented Mar 30, 2023

vladzcloudius left a comment

vladzcloudius Mar 31, 2023

tarzanek Aug 3, 2023

vladzcloudius Aug 4, 2023

igorribeiroduarte Aug 4, 2023

vladzcloudius Mar 31, 2023

tarzanek Apr 3, 2023

tarzanek commented Jun 2, 2023 •

edited

Loading

tarzanek commented Jun 26, 2023 •

edited

Loading

tarzanek commented Aug 1, 2023

tarzanek commented Aug 3, 2023 •

edited

Loading

tarzanek commented Aug 3, 2023 •

edited

Loading

tarzanek commented Aug 4, 2023 •

edited

Loading

igorribeiroduarte Aug 4, 2023

tarzanek Aug 7, 2023

vladzcloudius Aug 4, 2023

vladzcloudius left a comment

tarzanek commented Aug 7, 2023

tarzanek commented Aug 7, 2023 •

edited

Loading

tarzanek commented Aug 7, 2023

scylla role: support for 2022.2 (5.1) #232

Are you sure you want to change the base?

scylla role: support for 2022.2 (5.1) #232

Conversation

tarzanek commented Mar 3, 2023

tarzanek commented Mar 3, 2023

tarzanek commented Mar 6, 2023

Choose a reason for hiding this comment

tarzanek Mar 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarzanek commented Mar 30, 2023

tarzanek commented Mar 30, 2023

vladzcloudius left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarzanek commented Jun 2, 2023 • edited Loading

tarzanek commented Jun 26, 2023 • edited Loading

tarzanek commented Aug 1, 2023

tarzanek commented Aug 3, 2023 • edited Loading

tarzanek commented Aug 3, 2023 • edited Loading

tarzanek commented Aug 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vladzcloudius left a comment

Choose a reason for hiding this comment

tarzanek commented Aug 7, 2023

tarzanek commented Aug 7, 2023 • edited Loading

tarzanek commented Aug 7, 2023

tarzanek Mar 30, 2023 •

edited

Loading

tarzanek commented Jun 2, 2023 •

edited

Loading

tarzanek commented Jun 26, 2023 •

edited

Loading

tarzanek commented Aug 3, 2023 •

edited

Loading

tarzanek commented Aug 3, 2023 •

edited

Loading

tarzanek commented Aug 4, 2023 •

edited

Loading

tarzanek commented Aug 7, 2023 •

edited

Loading