Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scylla-node: remove ignore_errors, make node exporter from 2022 work #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tarzanek
Copy link
Collaborator

@tarzanek tarzanek commented Jan 8, 2024

2022 node exporter now works for clean install and upgrades

fix detection of node-exporter services

make sure the name of node exporter service matches the check

@tarzanek
Copy link
Collaborator Author

tarzanek commented Jan 8, 2024

I split away node exporter from #232

can you review @vladzcloudius or @igorribeiroduarte / @ebenzecri ?

@tarzanek
Copy link
Collaborator Author

tarzanek commented Jan 9, 2024

don't merge, I am trying to fix molecule

@tarzanek tarzanek force-pushed the node_exporter branch 6 times, most recently from 9baabd4 to a5093ff Compare February 28, 2024 17:27
@tarzanek
Copy link
Collaborator Author

tarzanek commented Feb 28, 2024

ok, molecule should pass now
@igorribeiroduarte @vladzcloudius this is just extract of reviewed and tested commit from #232

so please re-review, or check above, this will get rid of ignore errors for node exporter and properly use it for any Scylla version now

@tarzanek
Copy link
Collaborator Author

@vladzcloudius ping?

ansible-scylla-node/tasks/main.yml Outdated Show resolved Hide resolved
@vladzcloudius
Copy link
Collaborator

This PR has conflicts, please, rebase.

fix detection of legacy node-exporter services

in case old node exporter is running it will block new one from starting
so make sure old service is stopped before trying to run new one
@tarzanek
Copy link
Collaborator Author

rebased, but logic changed, I need to retest new condition

  when: (install_type == 'online') and (node_exporter_install.stat.exists) and ((scylla_package_prefix + '-node-exporter') not in ansible_facts.packages)

@tarzanek
Copy link
Collaborator Author

so basically classic situation when you have old 2021 Scylla and you upgrade needs to be retested with this new change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants