Skip to content

Commit

Permalink
fix(event): ignore raft transfer snapshot error
Browse files Browse the repository at this point in the history
Due to scylladb/scylladb#12972 SCT test fails.
But this issue is not severe and should not cause failure of the test.

Reduce severity of `raft - transfer snapshot error` to `WARNING` as per
developers request until issue is fixed.

(cherry picked from commit 9667ee1)
  • Loading branch information
soyacz authored and fruch committed May 7, 2023
1 parent 9d503b7 commit 4cdffb4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions defaults/severities.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ DatabaseLogEvent.COMPACTION_STOPPED: NORMAL
DatabaseLogEvent.RPC_CONNECTION: WARNING
DatabaseLogEvent.DATABASE_ERROR: ERROR
DatabaseLogEvent.STACKTRACE: ERROR
DatabaseLogEvent.RAFT_TRANSFER_SNAPSHOT_ERROR: WARNING
IndexSpecialColumnErrorEvent: ERROR
CassandraHarryEvent.failure: CRITICAL
CassandraHarryEvent.error: ERROR
Expand Down
6 changes: 6 additions & 0 deletions sdcm/sct_events/database.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ class DatabaseLogEvent(LogEvent, abstract=True):
RUNTIME_ERROR: Type[LogEventProtocol]
FILESYSTEM_ERROR: Type[LogEventProtocol]
STACKTRACE: Type[LogEventProtocol]
RAFT_TRANSFER_SNAPSHOT_ERROR: Type[LogEventProtocol]
DISK_ERROR: Type[LogEventProtocol]
COMPACTION_STOPPED: Type[LogEventProtocol]

Expand Down Expand Up @@ -123,6 +124,10 @@ def add_info(self: T_log_event, node, line: str, line_number: int) -> T_log_even
regex=r"storage_service - .*due to I\/O errors.*Disk error: std::system_error")
DatabaseLogEvent.add_subevent_type("STACKTRACE", severity=Severity.ERROR,
regex="stacktrace")
# scylladb/scylladb#12972
DatabaseLogEvent.add_subevent_type("RAFT_TRANSFER_SNAPSHOT_ERROR", severity=Severity.WARNING,
regex=r"raft - \[[\w-]*\] Transferring snapshot to [\w-]* "
r"failed with: seastar::rpc::remote_verb_error \(connection is closed\)")

# REACTOR_STALLED must be above BACKTRACE as it has "Backtrace" in its message
DatabaseLogEvent.add_subevent_type("REACTOR_STALLED", mixin=ReactorStalledMixin, severity=Severity.DEBUG,
Expand Down Expand Up @@ -166,6 +171,7 @@ def add_info(self: T_log_event, node, line: str, line_number: int) -> T_log_even
DatabaseLogEvent.FILESYSTEM_ERROR(),
DatabaseLogEvent.DISK_ERROR(),
DatabaseLogEvent.STACKTRACE(),
DatabaseLogEvent.RAFT_TRANSFER_SNAPSHOT_ERROR(),

# REACTOR_STALLED must be above BACKTRACE as it has "Backtrace" in its message
DatabaseLogEvent.REACTOR_STALLED(),
Expand Down

0 comments on commit 4cdffb4

Please sign in to comment.