fix(disrupt_terminate_and_replace_node): make it valid for gke #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
requested review from
bentsi and
enaydanov
and removed request for
bentsi
dkropachev
force-pushed
the
gke_terminate_and_replace
branch
6 times, most recently
from
c9c1d12
to
eddb382
Compare
dkropachev
force-pushed
the
gke_terminate_and_replace
branch
from
eddb382
to
701ce83
Compare
|
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
dkropachev
force-pushed
the
gke_terminate_and_replace
branch
3 times, most recently
from
a0bd52f
to
e3efc9e
Compare
bentsi
reviewed
Nov 10, 2020
sdcm/nemesis.py
Outdated
| if isinstance(self.cluster, GkeScyllaPodCluster): | ||
| terminate_method_name = random.choice(('terminate_k8s_host', 'terminate_k8s_node', 'terminate_node')) | ||
| self.log.info(f"Terminate node via {terminate_method_name}") | ||
| getattr(self.cluster, terminate_method_name)(self.target_node) |
bentsi
reviewed
Nov 10, 2020
sdcm/nemesis.py
Outdated
| @@ -539,7 +540,12 @@ def _add_and_init_new_cluster_node(self, old_node_ip=None, timeout=HOUR_IN_SEC * | |||
| return new_node | |||
|
|
|||
| def _terminate_cluster_node(self, node): | |||
| self.cluster.terminate_node(node) | |||
| if isinstance(self.cluster, GkeScyllaPodCluster): | |||
| terminate_method_name = random.choice(('terminate_k8s_host', 'terminate_k8s_node', 'terminate_node')) | |||
There was a problem hiding this comment.
allow terminate_node for both GKE and Minikube, raise for all other methods
dkropachev
force-pushed
the
gke_terminate_and_replace
branch
2 times, most recently
from
d964d9c
to
406883a
Compare
bentsi
reviewed
Nov 15, 2020
sdcm/cluster_gce.py
Outdated
| @@ -77,6 +77,10 @@ def init(self): | |||
|
|
|||
| super().init() | |||
|
|
|||
| @property | |||
| def instance_name(self): | |||
There was a problem hiding this comment.
create on the Base class too
There was a problem hiding this comment.
no need to override it now...
dkropachev
force-pushed
the
gke_terminate_and_replace
branch
from
406883a
to
2ba9a91
Compare
dkropachev
force-pushed
the
gke_terminate_and_replace
branch
from
2ba9a91
to
6a8f466
Compare
bentsi
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This nemesis is currently failing on the GKE due to the scylla-operator issue - scylladb/scylla-operator#215
PR pre-checks (self review)
backportlabelsNew configuration option are added and documented (insdcm/sct_config.py)I have added tests to cover my changes (Infrastructure only - underunit-test/folder)I have updated the Readme/doc folder accordingly (if needed)