Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(event): ignore raft transfer snapshot error #6094

Merged
merged 1 commit into from
May 7, 2023
Merged

fix(event): ignore raft transfer snapshot error #6094

merged 1 commit into from
May 7, 2023

Conversation

soyacz
Copy link
Contributor

@soyacz soyacz commented May 4, 2023

Due to scylladb/scylladb#12972 SCT test fails. But this issue is not severe and should not cause failure of the test.

Reduce severity of raft - transfer snapshot error to WARNING as per developers request until issue is fixed.

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

@soyacz soyacz requested review from fruch and kostja May 4, 2023 16:15
fruch
fruch previously approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch requested a review from fgelcer May 4, 2023 16:29
@soyacz
fix(event): ignore raft transfer snapshot error
a365528 
Due to scylladb/scylladb#12972 SCT test fails.
But this issue is not severe and should not cause failure of the test.

Reduce severity of `raft - transfer snapshot error` to `WARNING` as per
developers request until issue is fixed.
@soyacz soyacz force-pushed the mask-remote-verb-error-raft branch from c209c9f to a365528 Compare May 5, 2023 06:23
fgelcer
fgelcer approved these changes May 7, 2023
View reviewed changes
Copy link
Contributor

@fgelcer fgelcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fruch
fruch approved these changes May 7, 2023
View reviewed changes
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 9667ee1 into scylladb:master May 7, 2023
5 checks passed
@fruch fruch added backport/5.2 Need backport to 5.2 backport/2023.1 Need to backport to 2023.1 backport/2023.1-done Commit backported to 2023.1 backport/5.2-done Commit backported to 5.2 labels May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruch fruch fruch approved these changes

@fgelcer fgelcer fgelcer approved these changes

@kostja kostja Awaiting requested review from kostja

Assignees

@soyacz soyacz

Labels
backport/5.2-done Commit backported to 5.2 backport/5.2 Need backport to 5.2 backport/2023.1-done Commit backported to 2023.1 backport/2023.1 Need to backport to 2023.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@soyacz @fruch @fgelcer