Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade_test): scylla sstable dump verify with scylla.yaml #6982

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Dec 20, 2023

since there a fix not yet backported about the order that scylla sstable dumps is looking for the schema, we need to pass it the scylla.yaml for it to be able to read EaR sstables

Ref: https://github.com/scylladb/scylla-enterprise/issues/3702
Ref: scylladb/scylladb#16132

Testing

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

@fruch fruch added backport/5.4 Need backport to 5.4 backport/2024.1 Need backport to 2024.1 labels Dec 20, 2023
vponomaryov
vponomaryov previously approved these changes Dec 20, 2023
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

soyacz
soyacz previously approved these changes Dec 21, 2023
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch
Copy link
Contributor Author

fruch commented Dec 21, 2023

the change looks great, but didn't really fixed the issue:

22:16:42  Command: 'for i in `sudo find /var/lib/scylla/data/keyspace_complex/ -type f |grep -v manifest.json |grep -v snapshots |head -n 1`; do echo $i; sudo /usr/bin/scylla sstable dump-data --scylla-yaml-file /etc/scylla/scylla.yaml --sstables $i 1>/tmp/sstabledump.output || exit 1; done'
22:16:42  Exit code: 1
22:16:42  Stdout:
22:16:42  /var/lib/scylla/data/keyspace_complex/user_with_ck-74e9ddd09f5e11ee96136a49f71ddcaf/me-3gc2_1jb7_03fgg2hq30apvozl70-big-Scylla.db
22:16:42  Stderr:
22:16:42  error processing arguments: could not load schema via : std::invalid_argument (don't know which schema to load: --keyspace and/or --table are not provided)

I guess can specific the keyspace and table, assuming there's no multiple tables there..

since there a fix not yet backported about the order that `scylla
sstable dumps` is looking for the schema, we need to pass it
the scylla.yaml for it to be able to read EaR sstables

Ref: scylladb/scylla-enterprise#3702
Ref: scylladb/scylladb#16132
@fruch fruch dismissed stale reviews from soyacz and vponomaryov via cee268f December 21, 2023 08:45
@fruch
Copy link
Contributor Author

fruch commented Dec 24, 2023

specifying both the yaml and the keyspace/table is working

@fruch fruch merged commit 5aad817 into scylladb:master Dec 24, 2023
5 checks passed
@fruch fruch added backport/2024.1-done Commit backported to 2024.1 backport/5.4-done Commit backported to 5.4 labels Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/5.4-done Commit backported to 5.4 backport/5.4 Need backport to 5.4 backport/2024.1-done Commit backported to 2024.1 backport/2024.1 Need backport to 2024.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants